search

dotX12 / fastapi-gateway

⚙️ FastAPI gateway for microservices.
MIT License
107 stars 26 forks source link

If there is an optional parameter and support SteamingResponse #7

Open xitowzys opened 1 year ago

xitowzys commented 1 year ago

  1. When creating an optional parameter, it throws an error TypeError: Invalid variable type: value should be str, int or float, got None of type <class 'NoneType'>

  2. Support SteamingResponse

dotX12 commented 1 year ago

And I think I understand, you made a fork and posted it on pypi under your own name, okay :) I will review the proposal to add this PR this weekend. The work takes a lot of time in order to create open source projects...

xitowzys commented 1 year ago

And I think I understand, you made a fork and posted it on pypi under your own name, okay :) I will review the proposal to add this PR this weekend. The work takes a lot of time in order to create open source projects...

I apologize for the confusion that occurred here. I just want to continue developing this project further and was considering publishing it on PyPI with a different name under your fork. Also, I didn't realize that all subsequent changes would be reflected in Pull requests, as I'm still new to this process.

dotX12 commented 1 year ago

No big deal, it's because u opened a PR from your master to my master branch, so it merges all changes here. image

xitowzys commented 1 year ago

No big deal, it's because u opened a PR from your master to my master branch, so it merges all changes here. image

Only now I noticed that. Thank you. I hope you will find time to review my previous changes 🙂.