search

dotandimet / Mojo-Feed

Mojo::DOM based Feed Parser
Other
4 stars 1 forks source link

Rename documented private attribute to to_string #9

Closed mdom closed 6 years ago

mdom commented 6 years ago

I also made it to a function, to_string would be a weird name for an attribute. Or would you prefer to remove it all together? Mojo::Feed did not have an _raw attribute.

dotandimet commented 6 years ago

_raw was there for debugging (items because that's what my RSS reader was displaying), and it was documented because it was exposed to users when item was a hash. I was about to rename it myself, but wanted to do that in a seperate commit.

mdom commented 6 years ago

Oh, sorry, did not want to tip on your toes! I just saw it and thougt fixing would be just as fast as adding an issue.

dotandimet commented 6 years ago

Sorry, I didn't mean to imply you we stepping on my toes, I meant to say that this sounds like a good idea because I was thinking along the same lines myself. I've added a commit to overload stringification with to_string, like other Mojo::* classes.

mdom commented 6 years ago

On Thu, Mar 29, 2018 at 04:22:29AM -0700, Dotan Dimet wrote:

Sorry, I didn't mean to imply you we stepping on my toes, I meant to say that this sounds like a good idea because I was thinking along the same lines myself.

No worries then! :)

I've added a commit to overload stringification with to_string, like other Mojo::* classes.

Cool!