search

dotandimet / Mojo-UserAgent-Role-Queued

A role for Mojo::UserAgent that processes non-blocking requests in a rate-limiting queue.
Other
3 stars 2 forks source link

WIP: Memory leaks #8

Closed tyldum closed 6 years ago

tyldum commented 6 years ago

Possible fix for #7 More testing is needed to see if they fix the real problem, but nothing seems broken and my initial tests were good.

tyldum commented 6 years ago

Still leaks, needs more. It's the queue array that simply grows.

dotandimet commented 6 years ago

I think that's just how Perl arrays behave (shift doesn't shorten it). Does the queue ever empty? If so, maybe we can reset it i.e, $self->jobs([]) once that happens?

tyldum commented 6 years ago

Seems to grow forever, I can give that a try.

tyldum commented 6 years ago

That did not change anything. Array still grows. The "queue_empty" event is fired. I think maybe I need a more minimal code to test on.

tyldum commented 6 years ago

The changes made for 1.14 seems to fix all leaks I was seeing (about 12k/s). Nice work! Thank you! Closing this PR, as it is obsolete.