MongoDB Plugin: Allow discriminatorField to be empty

dotansimha / graphql-code-generator-community

MIT License

118 stars 155 forks source link

MongoDB Plugin: Allow discriminatorField to be empty #128

Open robertherber opened 3 years ago

robertherber commented 3 years ago

It'd be great to allow discriminatorField to be empty for the abstractEntity/union directives. In many cases determining type by property checking is sufficient.

What happens currently is:

For abstractEntity an error is thrown by codegen
For union an { undefined: string } property is added to the union type.

Urigo commented 3 years ago

Thanks @robertherber for the feature request! Do you think you could create a sample test for this new API on a draft PR and then we could iterate to get it in?

robertherber commented 3 years ago

I gave it a try yesterday but ran into trouble running the tests. Is there a simple guide for getting the environment setup locally?

Urigo commented 3 years ago

Thanks for trying @robertherber !

We've created a guide and it also has video tutorials for that, I would love to know if that is helpful for you: https://github.com/the-guild-org/Stack/blob/master/CONTRIBUTING.md