[typescript react-query] unused `pageParamKey` when calling `useInfiniteQuery`.

ndthinh8796 commented 2 years ago

Describe the bug Unused pageParamKey in file https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/react-query/src/fetcher-graphql-request.ts

I think this:

    return `export const useInfinite${operationName} = <
      TData = ${operationResultType},
      TError = ${this.visitor.config.errorType}
    >(
      pageParamKey: keyof ${operationVariablesTypes},
      client: GraphQLClient,
      ${variables},
      ${options},
      headers?: RequestInit['headers']
    ) =>
    ${hookConfig.infiniteQuery.hook}<${operationResultType}, TError, TData>(
      ${generateInfiniteQueryKey(node, hasRequiredVariables)},
      (metaData) => fetcher<${operationResultType}, ${operationVariablesTypes}>(client, ${documentVariableName}, {...variables, ...(metaData.pageParam ?? {})}, headers)(),
      options
    );`;

should be change to:

    return `export const useInfinite${operationName} = <
      TData = ${operationResultType},
      TError = ${this.visitor.config.errorType}
    >(
      pageParamKey: keyof ${operationVariablesTypes},
      client: GraphQLClient,
      ${variables},
      ${options},
      headers?: RequestInit['headers']
    ) =>
    ${hookConfig.infiniteQuery.hook}<${operationResultType}, TError, TData>(
      ${generateInfiniteQueryKey(node, hasRequiredVariables)},
      (metaData) => fetcher<${operationResultType}, ${operationVariablesTypes}>(client, ${documentVariableName}, {...variables, [pageParamKey]: metaData.pageParam }, headers)(),
      options
    );`;

EandrewJones commented 2 years ago

Any intention to fix this or should I create a PR?

The infinite query does not work correctly if it isn't passing the page param to the correct variable. Plus, even if you write a temporary solution, the generator overwrites the fix anytime you update your api and need to regenerate the hooks.

saihaj commented 2 years ago

@EandrewJones go for it! Would love to review and land it in :)

EandrewJones commented 2 years ago

Great -- will look to push something in the coming week or two.

Best

Evan Jones Website: www.ea-jones.com

On Sun, Oct 16, 2022 at 10:52 AM Saihajpreet Singh @.***> wrote:

@EandrewJones https://github.com/EandrewJones go for it! Would love to review and land it in :)

— Reply to this email directly, view it on GitHub https://github.com/dotansimha/graphql-code-generator-community/issues/174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2T6AKUYIEJSUNZNUCLH63WDQJCNANCNFSM5OR5NJPA . You are receiving this because you were mentioned.Message ID: @.***>

EandrewJones commented 2 years ago

@saihaj Will you please assign me the issue?