Disable fragmentMasking not working

[nemonemi]

Which packages are impacted by your issue?

No response

Describe the bug

Previously, when generating types from the graphql schema I would get a normal and expected type:

export type SomeMutation = { __typename: 'Mutation', myProject: { __typename: 'MyProject',... } | { __typename: 'MyProjectClosedError', message: string } | { __typename: 'MyProjectNotFoundError', message: string } | { __typename: 'SupplierNotFound', message: string } };

Now, the query contains fragments, but until now they were just a means of optimizing the queries.

After updating Codegen and MSW, I now get this:

export type SomeMutation = { __typename: 'Mutation', myProject: (
    { __typename: 'MyProject' }
    & { ' $fragmentRefs'?: { 'ProjectFirstLevelPropertiesFragmentFragment': ProjectFirstLevelPropertiesFragmentFragment;'ProjectSupplierFragmentFragment': ProjectSupplierFragmentFragment;'ProjectWorkflowStepsFragmentFragment': ProjectWorkflowStepsFragmentFragment } }
  ) | { __typename: 'MyProjectClosedError', message: string } | { __typename: 'MyProjectNotFoundError', message: string } | { __typename: 'SupplierNotFound', message: string } };

It's not just the structure that changed, but the whole model. This is not usable, any longer.

Your Example Website or App

I hope it is not needed, and it's just a configuration issue on my part.

Steps to Reproduce the Bug or Issue

...

Expected behavior

I expect that, unless I opt-in for a new behavior explicitly, that the schema is generated as previously.

Screenshots or Videos

No response

Platform

• OS: Linux
• NodeJS: 18.20.3
• graphql version: 16.7.1
• "@graphql-codegen/add": "5.0.3",
• "@graphql-codegen/cli": "5.0.2",
• "@graphql-codegen/client-preset": "4.3.0",
• "@graphql-codegen/introspection": "4.0.3",
• "@graphql-codegen/typescript": "4.0.7",
• "@graphql-codegen/typescript-document-nodes": "4.0.7",
• "@graphql-codegen/typescript-graphql-files-modules": "2.2.1",
• "@graphql-codegen/typescript-graphql-request": "6.2.0",
• "@graphql-codegen/typescript-msw": "3.0.0",
• "@graphql-codegen/typescript-operations": "4.2.1",
• "@graphql-codegen/typescript-react-query": "6.1.0",

Codegen Config File

import type { CodegenConfig } from '@graphql-codegen/cli';

const config: CodegenConfig = {
  overwrite: true,
  schema: 'libs/mocks/orchestrator-mocks/src/mocks/schema.graphql',
  documents: ['apps/**/*.graphql', 'apps/**/*.ts', 'libs/**/*.graphql', 'libs/**/*.ts'],
  generates: {
    'libs/mocks/orchestrator-schema/generated/': {
      preset: 'client',
      plugins: ['typescript-msw'],
      config: {
        futureProofEnums: false,
        fetcher: 'graphql-request',
        enumsAsConst: true,
        scalars: { Date: 'DateScalar', DateTime: 'Date' },
        nonOptionalTypename: true,
        presetConfig: {
          fragmentMasking: false
        }
      },
    },
    'libs/mocks/orchestrator-schema/generated/graphql.schema.json': {
      plugins: ['introspection'],
    },
  },
};

Additional context

No response

[nemonemi]

Please disregard this. I passed the property wrong.

It should be:

generates: {
  presetConfig: {
        fragmentMasking: false
      }
}

Instead of:

generates: {
  config: {
    presetConfig: {
        fragmentMasking: false
      }
  }
}