Rewrite Envelop plugins as Yoga plugins if they'd be better with Yoga hooks - Githubissues

dotansimha / graphql-yoga

🧘 Rewrite of a fully-featured GraphQL Server with focus on easy setup, performance & great developer experience. The core of Yoga implements WHATWG Fetch API and can run/deploy on any JS environment.

https://the-guild.dev/graphql/yoga-server

MIT License

8.26k stars 574 forks source link

Rewrite Envelop plugins as Yoga plugins if they'd be better with Yoga hooks #1732

Open ardatan opened 2 years ago

ardatan commented 2 years ago

~~Automatic/Manual Persisted Queries plugin~~
- ~~https://github.com/dotansimha/graphql-yoga/pull/1137~~
~~Response Cache (on top of the existing Envelop plugin)~~
- ~~https://github.com/dotansimha/graphql-yoga/pull/1359~~
Rewrite rate-limiter plugin by using the approach here;
- https://github.com/Urigo/graphql-mesh/blob/master/packages/plugins/rate-limit/src/index.ts#L29
- Consider allowing async visitors because cache's get/set methods are async
Consider rewriting tracing and monitoring plugins in platform agnostic way instead of using Node.js packages
- Sentry (pre-configured only put your key and that is it ™️) #1488
- Prometheus
- https://app.crisp.chat/website/af9adec5-ddfa-4db9-a4a3-25769daf2fc2/inbox/session_0193251d-5676-49c1-83a0-dfdfab3ee19c/
- https://app.crisp.chat/website/af9adec5-ddfa-4db9-a4a3-25769daf2fc2/inbox/session_88821587-54b0-4853-b522-e7f5dc7bc65a/
1377
https://github.com/dotansimha/graphql-yoga/pull/1741

FezVrasta commented 3 months ago

Does anyone have a solution for Sentry integration? The envelop plugin is not working anymore.

ardatan commented 3 months ago

Could you create a new issue by following our issue template? Thanks!