search

dotblue / nette-webimages

On-the-fly generated web images for your Nette app
Other
26 stars 17 forks source link

Links are now generated absolute, for easier use in emails. #2

Closed greeny closed 10 years ago

vojtech-dobes commented 10 years ago

Hm, I think this should be optional as sometimes relative paths to images are desirable, right? I am thinking about clear API...

<img n:src="// $imageId, 400, 300">
<img n:absoluteSrc="$imageId, 400, 300">
greeny commented 10 years ago

Yes, obviously there should be posibility to choose what link do you want. I think the first solution is much better, cause it has similar API as n:href ;)

vojtech-dobes commented 10 years ago

But the second is much more readable. I will keep this open for a while, maybe someone else will come with an opinion or suggestion.

vojtech-dobes commented 10 years ago

Merged in 22e06e7263c2f936c6ae8a13c7e305fac7e74d3c. I went for // after some consideration.