dotchen / LAV

(CVPR 2022) A minimalist, mapless, end-to-end self-driving stack for joint perception, prediction, planning and control.
https://dotchen.github.io/LAV/
Apache License 2.0
397 stars 68 forks source link

Is locs[0] equivalent to ego_locs? #28

Closed KP-Zhang closed 1 year ago

KP-Zhang commented 1 year ago

Hello, Thank you for your wonderful work.

When reading your code, I find that in temporal_lidar_painted_dataset.py locs[0] is equal to ego_locs. While, in temporal_bev_dataset.py, locs[0] is different from ego_locs. The disagreement caused by ego_locs = rotate_points(ego_locs, -angle, ego_locs[0]) + [offset/self.pixels_per_meter, 0] After rotating ego_locs, ego_locs[0] has already been changed, which will affect the following line. locs = rotate_points(locs, -angle, ego_locs[0]) + [offset/self.pixels_per_meter, 0] Is locs[0] supposed to be equivalent to ego_locs?

Thank you for your time.

dotchen commented 1 year ago

Yes, they are supposed to be the same, thank you for the catch, I just fixed it in the repo.

The correct order follows the one in temporal_lidar_painted_dataset