search

dotchen / LearningByCheating

(CoRL 2019) Driving in CARLA using waypoint prediction and two-stage imitation learning
MIT License
308 stars 102 forks source link

Issue when cloning this repo over the extracted Carla tarball #15

Closed t27 closed 4 years ago

t27 commented 4 years ago

In the instructions mentioned in the README and in the quickstart.sh, we first extract the Carla tarball and then clone this repository over that.

When we do this,

# Download LBC
git init
git remote add origin https://github.com/dianchen96/LearningByCheating.git
git pull origin release-0.9.6

After the last line, git aborts the pull process as there is a conflict in the LICENSE file. (the Carla zip also includes a LICENSE file with the same name)

The current workaround that I use is to add a simple rename command after the tar extraction and before git init like this

mv LICENSE LICENSE_CARLA

After this the git pull seems to work properly.

dotchen commented 4 years ago

Thanks for poinint this out! I made the instructions before adding the license file and I forgot to address that. Do you mind creating a PR with your fix above?

t27 commented 4 years ago

Sure, I'll update the readme and quickstart files