[bug] Fix node_* metrics on k8s-views-global.json

dotdc / grafana-dashboards-kubernetes

A set of modern Grafana dashboards for Kubernetes.

Apache License 2.0

2.63k stars 368 forks source link

[bug] Fix node_* metrics on k8s-views-global.json #111

Closed dotdc closed 6 months ago

dotdc commented 6 months ago

Describe the bug

Currently, there is no job label selector in k8s-views-global.json.

History:

A hardcoded job label was set to node-exporter in #36 for node_* metrics
They were after removed in #49 to work with Grafana Agent

Adding a job variable for node_* metrics should fix the issue.

@uhthomas @tlemarchand Can you both try the version in https://github.com/dotdc/grafana-dashboards-kubernetes/pull/110 to make sure it works on your side ?

tlemarchand commented 6 months ago

@dotdc It works for me. Thanks a lot for this fix !

uhthomas commented 6 months ago

@dotdc I think it's weird to support monitoring nodes which are not part of the Kubernetes cluster, but this seems like a reasonable change and should accommodate both.

dotdc commented 6 months ago

The query for the job variable is using the cluster variable, so I don't think this will be the case. Thanks, will merge #110 then.