search

dotdevelop / dotdevelop

MonoDevelop is a cross platform .NET IDE
http://www.monodevelop.com
299 stars 30 forks source link

libgit2sharp SSH support? #134

Open MakiWolf opened 10 months ago

MakiWolf commented 10 months ago

@lytico you have removed the mono version of this library, and switching to the offical one. Interesting that it is still building from nugetfallback. https://github.com/dotdevelop/dotdevelop/commit/216f01c79faef2f00cf690492e4f812665db685b

But now there are build errors when updating to a newer version of that library. Because the offical version have never merged the commits to run ssh see closed PR https://github.com/libgit2/libgit2sharp/pull/1072 and monodevelop have its own branch https://github.com/mono/libgit2sharp/commit/42e6e11e259d6b0fbcffb23dd54915cb56035789 and that was build from source code when building monodevelop

So what do to in future? Removing support for SSH or create a own fork again that supports SSH or commenting out SSH support and search for an other solution?.

Following errors occurs with offical version

"/__w/dotdevelop/dotdevelop/main/Main.sln" (default target) (1) ->
"/__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git.csproj" (default target) (64) ->
(CoreCompile target) -> 
  /__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git/CredentialsDialog.cs(110,12): error CS0246: The type or namespace name 'SshUserKeyCredentials' could not be found (are you missing a using directive or an assembly reference?) [/__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git.csproj]
  /__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git/XwtCredentialsDialog.cs(217,32): error CS0246: The type or namespace name 'SshUserKeyCredentials' could not be found (are you missing a using directive or an assembly reference?) [/__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git.csproj]
  /__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git/XwtCredentialsDialog.cs(209,10): error CS0246: The type or namespace name 'SshUserKeyCredentials' could not be found (are you missing a using directive or an assembly reference?) [/__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git.csproj]
  /__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git/GitRepository.cs(1194,46): error CS0246: The type or namespace name 'AuthenticationException' could not be found (are you missing a using directive or an assembly reference?) [/__w/dotdevelop/dotdevelop/main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git.csproj]
lextm commented 10 months ago

So what do to in future?

Get rid of libgit2sharp and shell out to git executable directly (what exactly Visual Studio did).