Added byte array parsing to obtain-document function

cguckes commented 3 years ago

That way you can use other sources than the file system for loading pdfs.

Description of your pull request

I needed the ability to load pdfs from other sources than files, in my case e-mails.

Why should it be considered?

It's a small change and it adds a lot of useful functionality.

Pull request checklist

Before submitting the PR make sure the following things have been done (and denote this by checking the relevant checkboxes):

[X] The code is consistent with Clojure style guide.
[X] All code passes the linter (clj-kondo --lint src).
[X] You've added tests (if possible) to cover your change(s).
[X] All tests are passing.
[X] The commits are consistent with the Git commit style guide.
[X] You've updated the changelog (if adding/changing user-visible functionality).

Thanks!

dotemacs commented 3 years ago

Hello @cguckes

Sorry that I didn't spot this before and thanks for your PR.

I've got a couple of pedantic suggestions, I hope you don't mind :)

instead of doing this merge: can you ensure that there are only non-merge commits in there?
if you can ensure that this commit's message: https://github.com/cguckes/pdfboxing/commit/5c968dd82d80e8a98e0e451212d32966c1bb6e00 conforms to the git commit style guide: https://chris.beams.io/posts/git-commit/

If this is too much work/annoying, let me know, and I'll do it.

Thanks

cguckes commented 3 years ago

@dotemacs, will do when I get the chance. Might be one or two days though...

dotemacs commented 3 years ago

On 9 Nov 2020, at 09:15, Christopher Guckes notifications@github.com wrote:

@dotemacs, will do when I get the chance. Might be one or two days though…

No rush, thank you :)

cguckes commented 3 years ago

Ok, wasn't as hard as I thought... Ok now?

dotemacs commented 3 years ago

Thanks great, thanks :)

dotemacs / pdfboxing