dotemacs / pdfboxing

Nice wrapper of PDFBox in Clojure
BSD 3-Clause "New" or "Revised" License
180 stars 38 forks source link

Fix for split-pdf #73

Closed dotemacs closed 1 year ago

dotemacs commented 1 year ago

Description of your pull request

Previously with-open was used to open the PDF document that would be split. Which is fine if you're just thinking about closing the file after you've split it. But it doesn't seem very useful, because once you've split the file, you probably want to do something with it.

I'm reverting this change introduced via 2ed58248360788cbdd4a4b5dbc95eadaddd9c767 just to get some opinions in this issue: https://github.com/dotemacs/pdfboxing/issues/46

Pull request checklist

Before submitting the PR make sure the following things have been done (and denote this by checking the relevant checkboxes):