Trait std::error::Error not implemented for dotenv::errors::Error

dotenv-rs / dotenv

Library to help supply environment variables in testing and development

MIT License

557 stars 88 forks source link

Trait std::error::Error not implemented for dotenv::errors::Error #23

Closed mkeedlinger closed 4 years ago

mkeedlinger commented 5 years ago

Much the same issue as here, but I'll put info here for simplicity.

Error is a trait that "[represents] the basic expectations for error values".

It should be easy to implement, the problem is that your implementation of failure::Fail conflicts because of the cause function. I was hoping there might be an updated version of failure that had fixed the issue and you could simply upgrade, but sadly the most recent version¹ still has the collision.

1: Version 0.1.5 at time of writing this

mkeedlinger commented 5 years ago

Ok, upon further inspection I've found that you've fixed this problem: https://github.com/dotenv-rs/dotenv/commit/cfed2b85f4c8ed2816973200e8a228abfd45fdab

It's just not pushed as a version to crates.io

I'm going to leave this issue open to discuss a best way forward. For now I'm going to switch to Github in my Cargo.toml.

SomeoneToIgnore commented 4 years ago

Does 0.15.0 contain this fix?

mkeedlinger commented 4 years ago

I don't have access to an IDE right now, but yes, it looks like 0.15.0 does indeed implement std::error::Error!

Thanks for the work that goes into this project!