search

dotenv-rs / dotenv

Library to help supply environment variables in testing and development
MIT License
557 stars 88 forks source link

Add variable substitution #4

Closed SomeoneToIgnore closed 5 years ago

SomeoneToIgnore commented 5 years ago

Hey, it would be great to finally support the variable substitution in the library, please tell me what you think about the implementation.

codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into master will increase coverage by 3.08%. The diff coverage is 96.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   85.95%   89.04%   +3.08%     
==========================================
  Files          17       18       +1     
  Lines         349      493     +144     
==========================================
+ Hits          300      439     +139     
- Misses         49       54       +5
Impacted Files Coverage Δ
dotenv/src/iter.rs 92.3% <100%> (-3.53%) :arrow_down:
dotenv/tests/test-variable-substitution.rs 94.11% <94.11%> (ø)
dotenv/src/parse.rs 98% <97.2%> (-0.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3550ce7...de771bf. Read the comment docs.

SomeoneToIgnore commented 5 years ago

Great, glad that you're fine with the earlier schedule for this one.

ZoeyR commented 5 years ago

@SomeoneToIgnore Would you mind writing some examples into the README on how to take advantage of the new feature?

SomeoneToIgnore commented 5 years ago

Sure, added.