search

dotenv-rs / dotenv

Library to help supply environment variables in testing and development
MIT License
566 stars 45 forks source link

WIP: Removing reference to readme #52

Closed rodoufu closed 4 years ago

rodoufu commented 4 years ago

Closes: #51

codecov[bot] commented 4 years ago

Codecov Report

Merging #52 into master will decrease coverage by 21.29%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #52       +/-   ##
===========================================
- Coverage   77.29%   56.00%   -21.30%     
===========================================
  Files          18       18               
  Lines         740     1016      +276     
===========================================
- Hits          572      569        -3     
- Misses        168      447      +279
Impacted Files Coverage Δ
dotenv/src/parse.rs 43.18% <0.00%> (-26.62%) :arrow_down:
dotenv/src/lib.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d15856...88676f2. Read the comment docs.

Plecra commented 4 years ago

I'm pretty sure we still want cargo to know about the README 😅 It's part of the crate's documentation, and can't just be thrown out like that. How about we follow serde's example and use a symlink?

rodoufu commented 4 years ago

I'm pretty sure we still want cargo to know about the README It's part of the crate's documentation, and can't just be thrown out like that. How about we follow serde's example and use a symlink?

It was breaking the build in a cargo +nightly version.