dotenv-rs / dotenv

Library to help supply environment variables in testing and development
MIT License
566 stars 45 forks source link

Generate helpful errors from dotenv! macro #53

Closed Plecra closed 4 years ago

Plecra commented 4 years ago

An implementation for #9

codecov[bot] commented 4 years ago

Codecov Report

Merging #53 into master will decrease coverage by 2.43%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   86.77%   84.33%   -2.44%     
==========================================
  Files           7        7              
  Lines         242      249       +7     
==========================================
  Hits          210      210              
- Misses         32       39       +7     
Impacted Files Coverage Δ
dotenv_codegen_implementation/src/lib.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c2ba38...31e48e8. Read the comment docs.

Plecra commented 4 years ago

What would you like me to do about those regressions? I'm pretty sure I haven't removed any tests, and the only changes I made were in the macro implementation

ZoeyR commented 4 years ago

I'll look into it, but its been long enough since code coverage was run, I wouldn't be surprised if its just something going wrong with the codecov tool

Plecra commented 4 years ago

Ooh, I can actually understand the report now. It's identified the couple error cases that I introduced but didn't test. I don't think it's worth putting together a compile error test harness for those couple cases though...

ZoeyR commented 4 years ago

@Plecra its also in codegen, which can't really be code coverage tested.

Plecra commented 4 years ago

Continued in #58