Create a template based on snippetman - Githubissues

dothq / browser-desktop

Dot Browser for Windows, macOS and Linux

http://developer.dothq.org/

Mozilla Public License 2.0

386 stars 25 forks source link

Create a template based on snippetman #61

Closed trickypr closed 2 years ago

trickypr commented 2 years ago

This is a template that is loosely based on the code for Snippetman. There are some things that should be noted:

[ ] I have no idea how your new build system works, so this doesn't integrate with it at all or bind to any specific gecko-dev version
[ ] I can only guarantee that this will work on linux. It might work on macos. It definitely won't work on Windows
[ ] There are a bunch of custom patches. I think that newer versions of gecko-dev they might be dead, so you might need to manually apply and export them

kierandrewett commented 2 years ago

Does this have xulStore at all?

trickypr commented 2 years ago

It looks like it is in /toolkit, so it should, however I have only used the sqlite module for persistence.

kierandrewett commented 2 years ago

And the usual components work like browserelement and jarfiles?

trickypr commented 2 years ago

Jar files work fine, but there is some jank that needs to be handled (which is mentioned in the readme) to get react hotreloading working. Browser elements should work, but I am not sure how react will handle them and they have no typescript types yet

kierandrewett commented 2 years ago

How could we get this functional on Windows?

trickypr commented 2 years ago

You would need to copy over the windows packaging code from browser/ or comm-centeral/mail

kierandrewett commented 2 years ago

Ah yes, okay I'm currently out right now but I will give this a look over ASAP.

kierandrewett commented 2 years ago

Few things that need changing but I am happy to merge as I can easily fix these myself.