search

dotintent / FlutterBleLib

Bluetooth Low Energy library for Flutter with support for simulating peripherals
Apache License 2.0
530 stars 194 forks source link

Nullsafety #586

Closed okocsis closed 3 years ago

okocsis commented 3 years ago

Hey, guys! I've made a lot of effort to port the dart codebase to a nullsafe environment. I would appreciate someone taking a look at it.

known issues: -not all of the test are compiling, although I've tried to make it work I've even ported some of the mocks to the new generated mocking scheme. FIXME: I think many of the test should be retired, in favour of general nullsafety. Please help me on that. -there was a bleadapter lifecycle fiasco, because the DevicesBloc destroyed the client on dispose(), making the internal adapter unreachable, after going to detail view. Although I have attempted to fix this by just removing the destroy client call from DevicesBloc.dispose() but I'm just not certain this was the right solution in terms of good design.

Thanks for taking the time!

Fixes #556

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

okocsis commented 3 years ago

@mikolak Okay so, it seems the new xcode image did the trick for travis, now phase two passes as well, but still fails on phase three package-analysis as follows: "package-analysis It seems that this action doesn't have the required permissions to call the GitHub API with the token you gave. This can occur if this repository is a fork, as in that case GitHub reduces the GITHUB_TOKEN's permissions for security reasons. Consequently, no report will be made on GitHub. Check this issue for more information: https://github.com/axel-op/dart-package-analyzer/issues/2"

I don't know how to fix this one mate.

mikolak commented 3 years ago

Yeah, it's because it's a PR from a fork instead of a MR from this repo - don't mind.