dotkernel / .github

MIT License
0 stars 0 forks source link

create .gitattributes.md template file #4

Closed arhimede closed 3 weeks ago

arhimede commented 1 month ago

and add it to frontend, admin and api repos

bidi47 commented 1 month ago

@alexmerlin, i recommend adding these lines, though i'm unsure about the export-ignore items (borrowed from Laminas)

* text=auto
*.png binary
*.md diff=markdown
/.github/ export-ignore
/.laminas-ci/ export-ignore
/.gitignore export-ignore
/phpcs.xml export-ignore
/psalm.xml export-ignore
/psalm-baseline.xml export-ignore
alexmerlin commented 1 month ago

@alexmerlin, i recommend adding these lines, though i'm unsure about the export-ignore items (borrowed from Laminas)

  • text=auto

Not sure if text=auto is the best approach here. We need to make sure that we always use lf, regardless the developer's OS. So maybe * text eol=lf would be the better option, because it forces LF on all platforms.

*.png binary

We might include some common image formats as well, like:

*.jpg binary
*.jpeg binary
*.svg binary

*.md diff=markdown

Why does Laminas export-ignore the below files?

/.github/ export-ignore /.laminas-ci/ export-ignore /.gitignore export-ignore /phpcs.xml export-ignore

If the rest of the XML files are already here, we should also add:

/phpunit.xml export-ignore

/psalm.xml export-ignore /psalm-baseline.xml export-ignore

bidi47 commented 1 month ago

the list below has your updates the open items that remains is should we ignore anything for the export?

* text eol=lf
*.png binary
*.jpg binary
*.jpeg binary
*.svg binary
*.md diff=markdown
alexmerlin commented 1 month ago

We can keep above ignore list.