dotkernel / admin

DotKernel Admin Application, built on top of Mezzio microframework and using Laminas components.ezzio for branch 2 and above.
https://admin5.dotkernel.net
MIT License
26 stars 5 forks source link

change theme to adminator #203

Closed arhimede closed 9 months ago

gitguardian[bot] commented 9 months ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [8876550](https://dashboard.gitguardian.com/incidents/8876550?occurrence=120222227) | Google API Key | b724c1896e2c3096002d1ec84ada804c52379196 | src/App/assets/js/components/_googleMaps.js | [View secret](https://github.com/dotkernel/admin/commit/b724c1896e2c3096002d1ec84ada804c52379196#diff-44e2f3a5baf288ebc41698c9b08fc54dfe28aaa1e55a7f2b86ed728f8f44aaddR7) | | [8876550](https://dashboard.gitguardian.com/incidents/8876550?occurrence=120307583) | Google API Key | bd8d6875b93bca349fb4e01ff2a78ebc8300a10b | src/App/assets/js/components/_googleMaps.js | [View secret](https://github.com/dotkernel/admin/commit/bd8d6875b93bca349fb4e01ff2a78ebc8300a10b#diff-44e2f3a5baf288ebc41698c9b08fc54dfe28aaa1e55a7f2b86ed728f8f44aaddL7) | | [8876550](https://dashboard.gitguardian.com/incidents/8876550?occurrence=121425496) | Google API Key | 17eee285f17d4ffc6bb6c6ee31e26f8c90442e52 | public/js/app.js | [View secret](https://github.com/dotkernel/admin/commit/17eee285f17d4ffc6bb6c6ee31e26f8c90442e52#diff-5fce35979168c627ed7dce97710171e070c0317cc9d31f4d133640b145a0d24cL842) | | [8876550](https://dashboard.gitguardian.com/incidents/8876550?occurrence=121428375) | Google API Key | 7a8566ec21409ca9b6e17c131b60490d60139d7b | public/js/app.js | [View secret](https://github.com/dotkernel/admin/commit/7a8566ec21409ca9b6e17c131b60490d60139d7b#diff-5fce35979168c627ed7dce97710171e070c0317cc9d31f4d133640b145a0d24cL842) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

codecov[bot] commented 9 months ago

Codecov Report

Attention: 160 lines in your changes are missing coverage. Please review.

Comparison is base (898439a) 71.05% compared to head (7a8566e) 65.22%.

Files Patch % Lines
src/Setting/src/Controller/SettingController.php 0.00% 89 Missing :warning:
src/Setting/src/Entity/Setting.php 0.00% 26 Missing :warning:
...g/src/InputFilter/Input/SettingIdentifierInput.php 0.00% 14 Missing :warning:
.../src/InputFilter/Input/SettingValueInputFilter.php 0.00% 10 Missing :warning:
src/Setting/src/Service/SettingService.php 0.00% 10 Missing :warning:
src/App/src/Controller/PageController.php 0.00% 4 Missing :warning:
src/Setting/src/Repository/SettingRepository.php 0.00% 4 Missing :warning:
src/Setting/src/InputFilter/SettingInputFilter.php 0.00% 2 Missing :warning:
src/Admin/src/Controller/AdminController.php 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.0 #203 +/- ## ============================================ - Coverage 71.05% 65.22% -5.84% - Complexity 328 363 +35 ============================================ Files 39 49 +10 Lines 1534 1734 +200 ============================================ + Hits 1090 1131 +41 - Misses 444 603 +159 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.