check the sendMail function to log error

dotkernel / api

DotKernel's PSR-7 REST style API built around the Mezzio API skeleton.

https://docs.dotkernel.org/api-documentation/

MIT License

35 stars 5 forks source link

check the sendMail function to log error #118

Closed arhimede closed 2 years ago

arhimede commented 2 years ago

connected to issue https://github.com/dotkernel/frontend/issues/289

arhimede commented 2 years ago

@bidi47 please check this one

bidi47 commented 2 years ago

i've found an instance where the mail send error isn't visible because both dot-mail and the frontend code that tries to send an email have try-catch statements

so even if dot-mail returns an message with the reason the email transfer failed, it's not an exception, so the frontend try-catch considers it a successful email transfer

what is the best way to proceed? to remove the try-catches from

frontend
or dot-mail (faster and allows the frontend to display custom error messages)

bidi47 commented 2 years ago

resolved in the most recent versions of dot-mail dot-mail 3.4.6 and 4.0.4