search

dotkernel / api

DotKernel's PSR-7 REST style API built around the Mezzio API skeleton.
https://docs.dotkernel.org/api-documentation/
MIT License
35 stars 5 forks source link

local.php.dist file mismatch #200

Closed arhimede closed 9 months ago

arhimede commented 1 year ago

the file local.php.dist from the repo is very different then the one online at api.dotkernel.net

(local-4.1.0.php )

Let's have a final local.php file

alexmerlin commented 1 year ago

Not sure how local.php looks right now on api.dotkernel.net. The last 2 modifications on local.php.dist were made on:

The diff between the last 2 commits is here and it contains only phpcs related modifications.

Can you post a diff between the latest local.php.dist and the local.php that is currently used on api.dotkernel.net?

arhimede commented 1 year ago

attached is the current file on api.dk

alexmerlin commented 1 year ago

At first look, the attached version is way too out-of-sync with the repo version, containing key/values that were removed long ago (e.g.: authentication->pdo, use Mezzio\Cors\Configuration\ConfigurationInterface;)

In order to clarify things, I'll go through each item:

  1. the header with a comment: the header comment has been removed because README.md instructs developers to duplicate config/autoload/local.php.dist as config/autoload/local.php
  2. use different namespaces: not sure what you mean because there is no namespace in neither the repo version nor the attached version. Instead, there are a some differences in the uses:
  1. PDO section: as I mentioned above, PDO section has been removed almost a year ago, more exactly in this commit after we made authentication use Doctrine vs the secondary PDO connection
  2. documentation section: that section has been removed back in 2021, when we moved our documentation from Swagger to Postman (in this commit)
alexmerlin commented 9 months ago

Closing this because we found out that local.php on api.dotkernel.net was not in sync with the one from the repo.