alexmerlin commented 4 weeks ago

This PR does the following:

simlify handler actions by removing responsability of handling exceptions
enhances handler response status codes based on the response / exception
handlers return HTTP status code based on response / exception
creates/uses case-specific exceptions instead of the generic ones
updates method docblocks with the correct exceptions thrown
capture code-level exception messages, log them to the daily log and rethrow the same type of exception with a safe message that can be shown in a UI
fixes user ResetPassword retrieval based on the hash from the path (vs always using the latest one)
minor code cleanups
replaced UUIDv1 usage with UUIDv4
restored #[ORM\HasLifecycleCallbacks] attribute to all entities extending our AbstractEntity because without that, the updatedAt field does not get populated
breaks ResponseTrait into HandlerTrait and ResponseTrait so that we can access *Response methods without including the handle method in a class
return 204 No Content on successful DELETE operations

Tasks remaining:

[x] fix any issues reported by the reviewers
[x] fix existing unit tests
[ ] add more unit tests

github-actions[bot] commented 4 weeks ago

Qodana for PHP

497 new problems were found

Inspection name	Severity	Problems
`Undefined class`	🔶 Warning	225
`Undefined method`	🔶 Warning	183
`Undefined namespace`	🔶 Warning	84
`Type mismatch in property assignment`	🔶 Warning	3
`Incompatible return type`	🔶 Warning	2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions

alexmerlin commented 3 weeks ago

@MarioRadu @cPintiuta When you have time, take another look at this PR and leave your feedback with any observations you have

alexmerlin commented 3 weeks ago

add 204 to DELETE 201 when a resource is uploaded for the first time

Implemented.

dotkernel / api

Issue #248: Refactored handlers #269

Qodana for PHP