search

dotkernel / dot-user-agent-sniffer

DotKernel component providing details about a device by parsing a user agent.
https://docs.dotkernel.org/dot-user-agent-sniffer/
GNU General Public License v3.0
3 stars 1 forks source link

processing time #4

Closed kakapiciu closed 1 year ago

kakapiciu commented 3 years ago

getting device information using return $this->deviceService->getDetails($userAgent); taske @ 0.39 - 0.83 s on development server

alexmerlin commented 3 years ago

Just benchmarked on my local machine using a batch of 71 useragents, processing times look fine. See the results:

One thing I noticed, though: Calling UserAgentSniffer with a 'weird' user agent will throw an error: $device = $this->deviceService->getDetails($userAgent);

ErrorException raised in file vendor/dotkernel/dot-user-agent-sniffer/src/Data/ClientData.php line 124: Message: Undefined index: engine

But, this is a different situation, I just opened an issue for it.

alexmerlin commented 1 year ago

@kakapiciu Is this issue still relevant?

kakapiciu commented 1 year ago

@alexmerlin not anymore after specific changes on project times went back to normal