search

dotkom / AMaCS

Committee application application for Online online.
5 stars 2 forks source link

Allow dragging cards to prioritize them #104

Closed torjusti closed 4 years ago

torjusti commented 6 years ago

Allows dragging cards to priotize them instead of the cards clearing, forcing you to readd them in the correct order.

The good: I think this is a better way to enable prioritization of cards.

The bad: I don't know if this is a better way of interacting with the system or not. I'm kinda torn?

The ugly: I removed 3 tests :angel: I haven't looked into how to test drag and drop, but I can check more carefully if I broke anything if this PR is something we want.

torjusti commented 6 years ago

I agree, but I looked into how to test this and I honestly don't know how it should/can be tested in a good way. Most of the logic which used to by handled by the code described in the 3 removed tests is now handled by the drag-n-drop HOC, and I don't know if there's much more that can be done than force-trigger the onSortEnd-method, but that seems kinda useless.

oleast commented 4 years ago

I still think this would be sweet AF, but it would also have to be re-written now, sorry :/