search

dotkom / AMaCS

Committee application application for Online online.
5 stars 2 forks source link

Setting height on icons as some browsers require a defined height #36

Closed niklasmh closed 7 years ago

niklasmh commented 7 years ago

Fixes both Edge and Safari, where Edge did not display SVG icons on the front page because IE/Edge interprets undefined as 0. Safari also has the same problem but they are using the inbuilt size defined in the SVG as default instead.

niklasmh commented 7 years ago

Fixed IE in the last commit as IE happens to require flex: 1 0 auto; (not only: flex: 1;) as the third parameter is set to 0 as default.

duvholt commented 7 years ago

I think the IE bug was fixed in IE11? Also shouldn't it be flex: 1 1 0% instead?

https://github.com/philipwalton/flexbugs#6-the-default-flex-value-has-changed

IMO it's not worth fixing IE bugs anymore (Edge is fine).

sklirg commented 7 years ago

Gdamnit, I also fixed this. #38