search

dotkom / Nibble2

App for buying food and drinks at the office
MIT License
5 stars 4 forks source link

Cleanup code in views #69

Closed FredrikAugust closed 6 years ago

FredrikAugust commented 6 years ago

Mainly just following eslint's complaints, but also ensuring consistent formatting. The for..of -> .forEach/.map/.reduce is due to (according to eslint) for..of requiring more resources to achieve the same as the array methods do (and there's not really any complexity added by changing).

FredrikAugust commented 6 years ago

Will remove the files now. No clue how they got added in as I used github's own merge resolution tool...

EDIT: And thank you, yesterday was indeed quite the blast.

FredrikAugust commented 6 years ago

Fixed map complaint in cbab7b8 and merge conflict files in 4bc3bb8 @sklirg.

FredrikAugust commented 6 years ago

Yep, well, I'll fix it now.

FredrikAugust commented 6 years ago

@aborysa Fixed in 8df96a7.

FredrikAugust commented 6 years ago

@sklirg Looks good to you too? I fixed your previous review.

sklirg commented 6 years ago

@sklirg Looks good to you too? I fixed your previous review.

Sorry I haven't responded yet. Dismissed my initial review since you've fixed my concerns.

FredrikAugust commented 6 years ago

Nudge.

sklirg commented 6 years ago

I dismissed my review, so feel free to do what you want 🎉

FredrikAugust commented 6 years ago

rm -rf / --no-preserve-root on the production machine as well?

sklirg commented 6 years ago

https://youtu.be/gJLIiF15wjQ?t=49