dotkom / design-system

Component library, maybe
https://design.online.ntnu.no
MIT License
4 stars 4 forks source link

Build with Webpack #140

Closed FluidSense closed 4 years ago

FluidSense commented 4 years ago

Build with Webpack

Our current build does not support the shorthand syntax for React.Fragment, i.e. <>.
I think that our choice of build tools should not decide our choice of syntax, thus I suggest moving us over to webpack. This also bumps our version in case the change is not fully equal to the last build method.

Alternatives & decisions

Babel vs. TypeScript Compiler tsc

Both fullfill our needs of transpiling the code to JS 5/-6, so the design system can be used for both JS and TS-projects. I landed on TSC as we already used TypeScript, and thus avoid adding another package for transpiling since TSC does this. Babel would also need another config file, while we already have a tsconfig.json that microbundle used.

Webpack vs. Microbundle

Microbundle could perhaps work if we precompile the files with tsc or Babel. Microbundle's internal transpiling is what causes problems for us in the first place and to use it with tsc or Babel would require twice the processing.