dotkom / onlineweb4

Web pages for Online, Linjeforeningen for Informatikk at NTNU
https://online.ntnu.no
MIT License
48 stars 23 forks source link

Add Online identifier to calendar event titles #3228

Closed jorgengaldal closed 1 month ago

jorgengaldal commented 2 months ago

Description of changes

Add identifier to calendar event titles to make it easier to differentiate Online's events from other events in one's calendar.

Code Checklist

Visual changes

Before
After
henrikhorluck commented 2 months ago

Thank you for the contribution!

I think this is a feature better served by the user making their own iCal proxy that performs that modification?

I think users should be able to color-code their calendar in a way that it is obvious which events are Online-related, and this is a quite noisy change limiting how much information can be shown in notifications and on small screens

junlarsen commented 2 months ago

I think this is a feature better served by the user making their own iCal proxy that performs that modification?

I would argue this change is totally fine and I doubt a lot of people would be interested in running a proxy.

henrikhorluck commented 2 months ago

I would argue this change is totally fine and I doubt a lot of people would be interested in running a proxy.

My second point still stands, that this does take up a lot of valuable space with IMO more likely than not not-valuable information, that the user should have other tools available to fix.

I would on the other hand be open to us using e.g. an official Online-color as the default color on the calendar, which I think should be supported? (Though it only appears to maybe only support CSS3 color names) https://datatracker.ietf.org/doc/html/rfc7986#section-5.9 (Does this mean we can color-code each event according to our committee colors 🤔)

junlarsen commented 2 months ago

A fixed color would be fine too imo.

henrikhorluck commented 1 month ago

I'm closing this as I don't think we want this exact change, but please propose a different option e.g. the online-color!