search

dotliquid / dotliquid

.NET Port of Tobias Lütke's Liquid template language.
http://dotliquidmarkup.org
Other
1.04k stars 299 forks source link

RegisterSafeType concurrent access error fixes #540

Open ozlemkzn opened 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.34%. Comparing base (abb7562) to head (71f9ebd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #540 +/- ## ======================================= Coverage 88.34% 88.34% ======================================= Files 69 69 Lines 2694 2694 Branches 631 631 ======================================= Hits 2380 2380 Misses 210 210 Partials 104 104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

microalps commented 1 month ago

@saikrishna35 Thank you for correcting the code. While it looks good, would be nice to add a test that can verify this (a) works now (b) doesn't break down the road.

saikrishna35 commented 1 month ago

@saikrishna35 Thank you for correcting the code. While it looks good, would be nice to add a test that can verify this (a) works now (b) doesn't break down the road.

Hi @microalps , I have raised one PR : https://github.com/ozlemkzn/dotliquid/pull/2..