Open aeleftheriadis opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.34%. Comparing base (
abb7562
) to head (f7d4d36
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please create corresponding tests for all the changed methods.
All the best,
Moshe Alfih microalps web services
On Fri, May 31, 2024 at 3:11 AM Athanasios Eleftheriadis < @.***> wrote:
Fix StandardFilters methods that parses object to string, that fixes floating point numbers with current that has different decimal separator such as comma.
You can view, comment on, or merge this pull request online at:
https://github.com/dotliquid/dotliquid/pull/546 Commit Summary
- 851c760 https://github.com/dotliquid/dotliquid/pull/546/commits/851c7609d666928f05a1124261ced12d66caf4d4 Fix floating numbers parse and respect culture
- 8154ca9 https://github.com/dotliquid/dotliquid/pull/546/commits/8154ca9d20c1396fb77ecaedf4cc7e71863974b7 Merge pull request #1 from aeleftheriadis/aeleftheriadis-tostring-convertostring
File Changes
(1 file https://github.com/dotliquid/dotliquid/pull/546/files)
- M src/DotLiquid/StandardFilters.cs https://github.com/dotliquid/dotliquid/pull/546/files#diff-ed457f6366183673afe68ec920874105e7f0ff783a3a0b59103e0f2861d35667 (14)
Patch Links:
- https://github.com/dotliquid/dotliquid/pull/546.patch
- https://github.com/dotliquid/dotliquid/pull/546.diff
— Reply to this email directly, view it on GitHub https://github.com/dotliquid/dotliquid/pull/546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPVGHSTVAA4K4AFI76TGTLZFAPCXAVCNFSM6AAAAABISIE3D6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDOMJRHEZDAOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
I have added more tests as you have requested @microalps
@microalps I have updated the tests as requested.
Fix StandardFilters methods that parses object to string, that fixes floating point numbers with current that has different decimal separator such as comma.