dotliquid / dotliquid

.NET Port of Tobias Lütke's Liquid template language.
http://dotliquidmarkup.org
Other
1.04k stars 299 forks source link

Fix floating numbers parse and respect culture #546

Open aeleftheriadis opened 1 month ago

aeleftheriadis commented 1 month ago

Fix StandardFilters methods that parses object to string, that fixes floating point numbers with current that has different decimal separator such as comma.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.34%. Comparing base (abb7562) to head (f7d4d36).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #546 +/- ## ======================================= Coverage 88.34% 88.34% ======================================= Files 69 69 Lines 2694 2694 Branches 631 631 ======================================= Hits 2380 2380 Misses 210 210 Partials 104 104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

microalps commented 1 month ago

Please create corresponding tests for all the changed methods.

All the best,

Moshe Alfih microalps web services

On Fri, May 31, 2024 at 3:11 AM Athanasios Eleftheriadis < @.***> wrote:

Fix StandardFilters methods that parses object to string, that fixes floating point numbers with current that has different decimal separator such as comma.

You can view, comment on, or merge this pull request online at:

https://github.com/dotliquid/dotliquid/pull/546 Commit Summary

File Changes

(1 file https://github.com/dotliquid/dotliquid/pull/546/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/dotliquid/dotliquid/pull/546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPVGHSTVAA4K4AFI76TGTLZFAPCXAVCNFSM6AAAAABISIE3D6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDOMJRHEZDAOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

aeleftheriadis commented 1 month ago

I have added more tests as you have requested @microalps

aeleftheriadis commented 1 month ago

@microalps I have updated the tests as requested.