search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

Fix null storeid #514

Closed barbazul closed 6 years ago

barbazul commented 6 years ago

Fixes #512

barbazul commented 6 years ago

I made the fix starting from master and then had to send the PR to develop because master is blocked apparently.

This caused a lot of "merge" commits to be added to the PR, instead of my single commit.

If this proves to be too confusing to the reviewers, I can resend the PR starting from a develop branch

simon-letch commented 6 years ago

Hey @barbazul,

Thanks for the contribution!

We're in the middle of a sprint at the moment. Will try to squeeze in the review as part of this sprint, but if not it will get prioritised for next sprint.

Thanks, Simon

barbazul commented 6 years ago

Awesome.

Good luck with your Sprint!!

barbazul commented 6 years ago

Hey guys. Any updates on this?