dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
49 stars 63 forks source link

Module breaks subject encoding #517

Closed xpoback closed 6 years ago

xpoback commented 6 years ago

Magento 2.2.5 Module: 2.5.0

Steps to reproduce:

  1. Create an email template in backend (Marketing->Email Templates) with a character like äüöß in Template Subject

Expected result:

  1. The characters are displayed correctly
  2. It is possible to edit template subject afterwards

Actual result:

  1. There's a question mark on the place of the character
  2. The field is empty on an attempt to edit template

The source of the problems: line one and line two Also why are you processing template data in the plugin even if the module is not enabled? How can you be sure the encoding is not correct? Please, fix.

pusachev commented 6 years ago

Same issue Magento 2.2.5 Module: 2.5.0

adeelq commented 6 years ago

@xpoback Thanks for reporting this. We are working on this in current sprint.

xKmz commented 6 years ago

@adeelq Any solution?

xpoback commented 6 years ago

@xKmz I'd suggest to disable the module or the plugin. https://github.com/magento/magento2/issues/15620#issuecomment-406292766

zaietsv commented 6 years ago

The same issue at version 2.2.6 http://screenshots.collabstar.com/vza/df6f2ab5.png

zaietsv commented 6 years ago

The Dotmailer plugin decodes a gorgeous utf-8 string to a terrible creature by utf8_decode() function http://screenshots.collabstar.com/vza/dd9f6cc8.png It is necessary to rewrite or to disable private function getProcessedTemplatePreviewAndOther() and private function getResultIfArgsEmptyForPreviewAndOther()

zhulak commented 6 years ago

I can confirm this issue and would like to see a fix for this as well

simon-letch commented 6 years ago

Hey,

We've released the fix for this in v3.0.2 with this commit: 635a62c

Thanks, Simon

zaietsv commented 5 years ago

Magento team just near about of starting to accept this fix https://github.com/magento/magento2/issues/15620#issuecomment-461432405 They are pretty fast developers