search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

CustomerPlugin definition - buggy code #546

Closed nileshti closed 5 years ago

nileshti commented 5 years ago

This logic in CustomerPlugin class is buggy one, How one can write Plugin for Protected function sendNewAccountEmail? This code will never execute with Magento 2.3.1.

simon-letch commented 5 years ago

Hey @nileshti,

Unless i'm missing something, that function is public in Magento 2.3.1: https://github.com/magento/magento2/blob/2.3.1/app/code/Magento/Customer/Model/Customer.php#L763

simon-letch commented 5 years ago

I'm going to close this issue, but please re-open if you can share more info.