search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

Move getConfigurableParentUrl and getSmallImageUrl block methods to b… #548

Closed adamj88 closed 5 years ago

adamj88 commented 5 years ago

…e available for all product list templates

Resolves #547

Moves the getConfigurableParentUrl and getSmallImageUrl methods to Block/Recommended which all relevant block files will inherit these methods from.

benathomeofchampions commented 5 years ago

Thanks for providing this PR, an excellent idea!

benathomeofchampions commented 5 years ago

Would you mind bringing your branch up to date with develop, then we can merge? Thanks again!

adamj88 commented 5 years ago

@benathomeofchampions I think you've managed to get in on the develop branch ok now and this can be closed?

In the meanwhile I've tested this in production environment and it works fine, previously all links were empty and they're now correctly populated with product URLs.

simon-letch commented 5 years ago

Thanks for the contribution @adamj88

It's in develop branch and authored correctly, so i'm going to close this.