search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

m2.3.5-p1 Dicompile error dotmailer #563

Closed alexbk31 closed 4 years ago

alexbk31 commented 4 years ago

after upgrading to m2.3.5-p1 ive updated all my extentions and there all working fine but now dotmailer is causing an decompile error

Compilation was started. Interception cache generation... 6/8 [===========>---] 75% 3 mins 470.0 MiBErrors during compilation: Dotdigitalgroup\Email\Model\Apiconnector\EngagementCloudAddressBookApi Incompatible argument type: Required type: \Dotdigitalgroup\Email\Logger\Logger. Actual type: \Dotdigitalgroup\Email\Helper\File; File: /home/healthcb/public_html/vendor/dotmailer/dotmailer-magento2-extension/Model/Apiconnector/EngagementCloudAddressBookApi.php

Total Errors Count: 1

In Log.php line 92:

Error during compilation

sta1r commented 4 years ago

@alexbk31 do you have an existing alias for this module in your composer.json file?

2.3.5-p1 comes bundled with 4.4.0 of this extension, and the file Model/Apiconnector/EngagementCloudAddressBookApi.php does not exist in this version:

https://github.com/dotmailer/dotmailer-magento2-extension/tree/v4.4.0/Model/Apiconnector

alexbk31 commented 4 years ago

Thanks for your response I did think it shouldn't be there when I upgraded its the only file with an old date on

im not sure if we had an existing alias for this module in composer.json we was on m2.3.3 we didn't have a dotmail digital account until now

dotmail

alexbk31 commented 4 years ago

sorted thanks I just removed all the files that were left behind now all working thanks

alexbk31 commented 4 years ago

do have the file tree for 4.4.0 the one on the link is 3.6.0

sta1r commented 4 years ago

@alexbk31 the v4.4.0 file tree is the right one i.e. as per the 2.3.5-p1 bundle, but well spotted the version is still 4.3.6. I will fix this and update the tag.