dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

\Dotdigitalgroup\Email\Model\Sync\Importer\ImporterProgressHandler::_processContactImportReportFaults() suppressed contacts resubscription #565

Closed naliva closed 3 years ago

naliva commented 4 years ago

in version 4.5.4 according to change log following has been changed:

I'm concerned that you are checking "last_subscribed_at" in this method instead of checking additionally email_contact.suppressed. From the situation we've faced it has resubscribed the record which had email_contact.suppressed=1 and email_contact.last_subscribed_at=null. Your change in 4.5.4 version handles this situation but you are referring to last_subscribed_at filtering instead of email_contact.suppressed so i believe this filtering is indirect and still there might happen situations where suppressed contacts have last_subscribed_at!=null and they are resubscribed (i never faced such situation but it might occur)

sta1r commented 4 years ago

@naliva Thanks for raising this.

From our most recent testing we're confident that the NULL check on email_contact.last_subscribed_at is sufficient to catch genuine resubscribes. However we're going to look again in light of this issue and I'll update here in due course.

In the meantime, if you are able to replicate contacts with recent last_subscribed_at dates, who are also email_contact.suppressed = 1, that would be useful.

sta1r commented 3 years ago

@naliva We've released an improvement to our handling of resubscribes from the contact import report. Thanks again for raising this.