dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

Dotdigitalgroup\Email\Model\Product::getProductIdsBySkuInBunch missing product Ids #567

Closed darrenf-fisheye closed 4 years ago

darrenf-fisheye commented 4 years ago

Dotdigitalgroup\Email\Model\Product::getProductIdsBySkuInBunch is returning the array_keys of the collection and not the product id's as expected by Dotdigitalgroup\Email\Model\Catalog::processBatch

Replacing the following in Dotdigitalgroup\Email\Model\Product::getProductIdsBySkuInBunch fixes the issue: $productIds = array_keys($productItems);

with: $productIds = []; foreach($productItems as $product){ $productIds[] = $product->getId(); }

sta1r commented 4 years ago

@darrenf-fisheye Hi, and thanks for raising this. We're going to resolve as soon as we can.

sta1r commented 4 years ago

Hi again, we've got a fix here: https://github.com/dotmailer/dotmailer-magento2-extension/commit/fc559c86939a677d583279187cb97bab6cce67d4 which we're planning to release to master on October 7.

sta1r commented 4 years ago

Now released!