search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

Previously public functions changed to private, breaking Plugins #583

Closed CsSatter closed 2 years ago

CsSatter commented 2 years ago

Although PHP standards may dictate certain class methods to be private, Magento's Interceptor implementation requires methods to be public for things like Plugins to work correctly. Example being previously made Plugin on \Dotdigitalgroup\Email\Model\Connector\Order::_getOrderItemOptions.

sertlab commented 2 years ago

Hi thanks for sharing the issue. In our next release we're planning to make Order::_getOrderItemOptions function public again.

CsSatter commented 2 years ago

Excellent, thanks for the update (and my apologies for the delayed response).