search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

Extension doesn't support PHP 8.1. #593

Closed kenitchiu closed 2 years ago

kenitchiu commented 2 years ago

Hi,

We have a Magento v2.4.5 instance running on PHP 8.1 environment, we tried to install this extension and composer showed it doesn't support php 8.1. Do you guys have any plan to add the support of PHP 8.1?

sta1r commented 2 years ago

@kenitchiu It should work fine, what's the exact error you get?

kenitchiu commented 2 years ago

I believe the error is due to there is a PHP version limitation ^8.0 in the composer.json file, so the composer doesn't allow the extension be installed in 8.1 environment.

sta1r commented 2 years ago

The constraint ^7.2||^8.0 is equivalent to '>=7.2 <8.0' OR '>=8.0 <9.0'.

vacla commented 2 years ago

I can confirm this, https://github.com/dotmailer/dotmailer-magento2-extension/blob/master/Model/Consent.php#L205 , it is possible that "$customerConsentText" can return null, causing it to fail.

sta1r commented 2 years ago

@vacla Thanks, we're aware of that one. In general we do support 8.1, we did a pretty thorough sweep for possible errors a few months ago. The odd issue does still crop up but we're repairing those as quickly as we can.

sta1r commented 2 years ago

@vacla a quick fix for that particular issue is to enter text into the text boxes in Dotdigital > Configuration > Consent. But we'll be fixing this in 4.19.4, released next week.