search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 63 forks source link

Di Compilation breaks Magento 2.4.3 PHP 7.2 #602

Closed nishpatel closed 1 year ago

nishpatel commented 1 year ago

Updated to version 4.2.0 of Magento 2 extension.

Di Compilation fails two files which are causing this issue:

Dotdigitalgroup\Email\Observer\Adminhtml\ResetCustomerImport Line 39 trailing comma

Dotdigitalgroup\Email\Model\Sync\Automation\AutomationProcessor Line 134 catch hasn't a variable.

sta1r commented 1 year ago

@nishpatel Thanks for flagging, we'll sort this out.

sta1r commented 1 year ago

I'm presuming you mean: Magento 2.3.4 (since 2.4.3 doesn't run on 7.2) and 4.20.0?

dbashyal commented 1 year ago

Same issue here. Sent an email to the support team. I can't believe this hasn't been fixed in 5 days. I wasted so much of my time as I didn't know what was causing the issue. 

MiBsyntax error, unexpected ')', expecting variable (T_VARIABLE)#0  vendor/composer/ClassLoader.php(346)
TomJ1588 commented 1 year ago

Can confirm, dotmailer v4.20 or os-package 1.6.0 breaks compile with the mentioned error on Magento 2.4.3-p3

sta1r commented 1 year ago

Hi folks, we're going to patch this for you ASAP. 4.20.1 coming tomorrow I hope.

sta1r commented 1 year ago

4.20.1 is released: https://github.com/dotmailer/dotmailer-magento2-extension/releases/tag/v4.20.1

You can get this from Packagist now. A new metapackage (1.6.1) will be available on the marketplace later today.