search

dotmailer / dotmailer-magento2-extension

The official Dotdigital for Magento2 extension
https://dotdigital.com/integrations/magento
MIT License
48 stars 64 forks source link

Handle NULL Consent Text Values #612

Closed pykettk closed 1 year ago

pykettk commented 1 year ago

Add type safety for strlen() function parameter

sta1r commented 1 year ago

@pykettk Thanks for this. We've actually been working on this area of the code, and have deprecated the method you're modifying here, see https://github.com/dotmailer/dotmailer-magento2-extension/blob/develop/Model/Consent.php#L81-L82. The newer code prevents the error you've run into.

This isn't due to be released until September however. In the meantime, if this is a major issue for you, we can release a patch - otherwise I'd advise either setting consent text in the admin or (if you don't need it) disabling consent capture.

pykettk commented 1 year ago

Thanks for the reply, @sta1r . It's not a major issue as I applied this change as a Composer patch. I can live with this as a solution until the September release 👍