feat(tags): Add tags - Githubissues

dotmap / devise-ante

Frontend for Devise.

Apache License 2.0

0 stars 1 forks source link

feat(tags): Add tags #37

Closed astra137 closed 6 years ago

puregarlic commented 6 years ago

@maccelerated, great work. A couple changes would be great:

Change the metadata section into an inline form for item labels
Prevent users from adding a second tag with the same name (pop a Message)
Tweak the tag transitions
Remove the name and ID from the tag popover, that info doesn't need to be displayed.

astra137 commented 6 years ago

Using a different transition for tags seemed like it was going to take more time than I wanted to invest tonight. Since nothing else on that view transitions between elements, I figure no transition is fine on tags too. I'm sorry I didn't launch b0f6dbf in ∆ now. If you want me to, I'll look into my build issues further.

puregarlic commented 6 years ago

If you try a ∆ now deployment, do you run into #39?

astra137 commented 6 years ago

Removing elements is broken after the state changes I made. I will fix and commit.

astra137 commented 6 years ago

https://devise-feat-tags-eydlfesepi.now.sh