dotmesh-io / dotmesh

dotmesh (dm) is like git for your data volumes (databases, files etc) in Docker and Kubernetes
https://dotmesh.com
Apache License 2.0
539 stars 29 forks source link

glog considered bad practice - rip it out and use something more standard #565

Open Godley opened 6 years ago

Godley commented 6 years ago

reasons from twitter

Using glog on operator - we should move toward something better, and more generally, make sure we're now using one, good logging library across all components (whatever gateway is using is probably right?)

rusenask commented 6 years ago

Gateway is using logrus https://github.com/sirupsen/logrus which is quite easy to use and is very flexible (we can later on add some hooks, like errors to sentry if we want to).

Another good option is https://github.com/uber-go/zap. I use zap too, but it's a bit more hassle and you basically have to pass it through the structs which is fine. But it is a hassle: )

Pros of logrus:

Pros of zap: