dotmesh-io / dotmesh

dotmesh (dm) is like git for your data volumes (databases, files etc) in Docker and Kubernetes
https://dotmesh.com
Apache License 2.0
538 stars 29 forks source link

[0.5d INTERRUPTION] Make push/pull compression optional #631

Closed alaric-dotmesh closed 5 years ago

alaric-dotmesh commented 5 years ago

User requirement

As a dotmesh dev, I want to know if compression on push/pull is a net win or loss in some situations, so I can get the best performance for my users.

Key acceptance criteria

alaric-dotmesh commented 5 years ago

Further research has confirmed that compression is a problem in our test env, so we're turning it off for now without an env var to turn it back on. Changing this is an easy fix if required, see the call to gzip.NewWriterLevel in dotmesh:pkg/utils/io.go.

alaric-dotmesh commented 5 years ago

This seems to be passing tests, so I can call it a wrap I think. The change is too trivial to bother with code review.