search

dotmesh-io / dotmesh

dotmesh (dm) is like git for your data volumes (databases, files etc) in Docker and Kubernetes
https://dotmesh.com
Apache License 2.0
539 stars 29 forks source link

Always put all properties in a json file #677

Closed alaric-dotmesh closed 5 years ago

alaric-dotmesh commented 5 years ago

We're seeing this:

time="2019-05-01T09:56:37Z" level=info msg="Transfer status polled" elapsed_ns=0 index=1 message="Attempting to pull 5cb9a444-e8dc-49de-68d9-c1aa759cc01a got <Event failed-applying-prelude: err: \"Error applying prelude: [set io.dotmesh:meta-run.fc40798b-507b-420a-99ec-e6bfc8b34bbc.description= pool/dmfs/5cb9a444-e8dc-49de-68d9-c1aa759cc01a@51c63419-e8a0-4049-5af9-42dbb6393282] -> exit status 2: missing value in property=value argument\\nusage:\\n\\tset <property=value> <filesystem|volume|snapshot>

We seem to be setting a zfs commit property to an empty string.

As setting those properties is rumoured to take a second or so each, we should bite the bullet and always put the properties in .json rather than only if they're big.