#788: Before we transition to active, make sure we finish snapshotting. - Githubissues

dotmesh-io / dotmesh

dotmesh (dm) is like git for your data volumes (databases, files etc) in Docker and Kubernetes

https://dotmesh.com

Apache License 2.0

539 stars 29 forks source link

#788: Before we transition to active, make sure we finish snapshotting. #790

Closed itamarst closed 4 years ago

itamarst commented 4 years ago

Fixes #788

If end-to-end tests pass, another candidate for @lukemarsden to test.

https://gitlab.dotmesh.com/dotmesh/dotmesh/pipelines/27672

itamarst commented 4 years ago

On Slack Luke suggested that the missing state is not involved, but if I create a new project in the gateway I see this in the dotmesh logs:

time="2020-01-21T18:00:57Z" level=info msg="entering missing state for 3f61e728-87a5-4a81-bab8-10f716f4f284" filesystem_id=3f61e728-87a5-4a81-bab8-10f716f4f284

Which suggests this is indeed the relevant code path.

itamarst commented 4 years ago

Tests appear to be passing.

itamarst commented 4 years ago

https://gitlab.dotmesh.com/dotmesh/dotmesh/pipelines/27725

itamarst commented 4 years ago

After conversation with Luke, this seems to be the correct fix, and just awaiting seeing if he can test and see if it stops the issue (since given the race-condition-y nature of the problem I was never able to reproduce).