search

dotmesh-io / python-sdk

dotmesh python sdk
Apache License 2.0
6 stars 1 forks source link

Fix jsonrpc client #11

Closed binocarlos closed 5 years ago

binocarlos commented 5 years ago

The latest version of jsonrpcclient.clients.http_client requires us to access res.data.result to extract the actual data returned as documented here

This PR returns res.data.result wherever we are using the jsonrpc client

lukemarsden commented 5 years ago

Can you declare the dependency with the new API explicitly?

lukemarsden commented 5 years ago

Ah, we do already: https://github.com/dotmesh-io/python-sdk/blob/master/setup.py#L24

lukemarsden commented 5 years ago

LGTM, and you've tested this and it works?

binocarlos commented 5 years ago

Yeah did a bunch of manual testing and ran the test script Michael had included :+1:

lukemarsden commented 5 years ago

btw, I don't think you need .data.result on requests where you're throwing away the response (i.e. not returning it or assigning it to a variable)

lukemarsden commented 5 years ago

maybe just make a followup issue to tidy that up