Closed binocarlos closed 5 years ago
Can you declare the dependency with the new API explicitly?
Ah, we do already: https://github.com/dotmesh-io/python-sdk/blob/master/setup.py#L24
LGTM, and you've tested this and it works?
Yeah did a bunch of manual testing and ran the test script Michael had included :+1:
btw, I don't think you need .data.result
on requests where you're throwing away the response (i.e. not returning it or assigning it to a variable)
maybe just make a followup issue to tidy that up
The latest version of
jsonrpcclient.clients.http_client
requires us to accessres.data.result
to extract the actual data returned as documented hereThis PR returns
res.data.result
wherever we are using the jsonrpc client